Handle clrdbg to vsdbg rename #501
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WardenGnaw
reviewed
Nov 17, 2016
| pushd %DESTDIR% | ||
| ren dummy.exe OpenDebugAD7.exe | ||
| if NOT "%ERRORLEVEL%"=="0" echo ERROR: Unable to rename OpenDebugAD7.exe???& exit /b -1 | ||
| pushd %destdir% |
There was a problem hiding this comment.
Accidental 'gu' of these three lines?
chuckries
reviewed
Nov 18, 2016
| if NOT exist "%DESTDIR%\%%~nd" mkdir "%DESTDIR%\%%~nd | ||
| for %%f in (%%d\*.dll) do call :InstallFile "%%f" %%~nd\ | ||
| ) | ||
|
|
||
| REM Rename vsdbg back to clrdbg |
There was a problem hiding this comment.
is it worth having this part behind an option so we can toggle whether to rename it or not?
There was a problem hiding this comment.
I don't think so, these scripts are already forked, so I don't expect there to be much more long-term use for them.
chuckries
reviewed
Nov 18, 2016
| for dll in $(ls $directory/*.dll); do | ||
| install_file "$dll" "$directory_name/" | ||
| done | ||
| done | ||
|
|
||
| # Rename vsdbg back to clrdbg | ||
| mv "$DESTDIR/vsdbg" "$DESTDIR/clrdbg" |
WardenGnaw
approved these changes
Nov 18, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@gregg-miskelly @chuckries @WardenGnaw